feat: add "use_interface_return_types" option #3125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jesse0Michael
force-pushed
the
WithTx-interface
branch
from
e55bd5d to
37d14e9
Compare
|
It would be nice if we could just update the WithTx signature to use "Querier" instead of "*Queries" if My hope is that we could put the change behind an explicit option. I imagine |
Jesse0Michael
force-pushed
the
WithTx-interface
branch
from
37d14e9 to
edb6745
Compare
Add an option to direct sqlc generation to use the querier interface for the return type of the WithTx method on the Queries struct. Include WithTx in the Querier interface (when "emit_methods_with_db_argument" is false)
kyleconroy
force-pushed
the
WithTx-interface
branch
from
edb6745 to
1cb85e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the option "use_interface_return_types" to direct sqlc generation to use the querier interface for the return type of the WithTx method on the Queries struct.
Include
WithTxin the Querier interface (when "emit_methods_with_db_argument" is false)Looks to resolve #383
Where the lack of
WithTxin the interface causes makes it hard to use theQuerierinterfaceand the
*Queriesreturn type makes it hard to mock the sqlcQuerierfor testingPlease let me know if I should have approached this differently or if there's something else I need to do! ✌️